From b06a76ca05fc9abd51639d819115c78bf8b05d55 Mon Sep 17 00:00:00 2001 From: Marijn Kampf Date: Wed, 24 Jan 2024 16:01:56 +0000 Subject: [PATCH 1/2] Enable status active/complete filter --- src/client/components/Dashboard/my-tasks/state.js | 6 ++++-- test/functional/cypress/fakers/task.js | 1 + .../cypress/specs/dashboard/filter-spec.js | 13 +++++++++---- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/client/components/Dashboard/my-tasks/state.js b/src/client/components/Dashboard/my-tasks/state.js index ca8fc912ba5..d7c2d0d2a46 100644 --- a/src/client/components/Dashboard/my-tasks/state.js +++ b/src/client/components/Dashboard/my-tasks/state.js @@ -30,9 +30,10 @@ const sortbyMapping = { company_ascending: 'company.name:asc', project_ascending: 'investment_project.name:asc', } + const statusMapping = { - active: { archived: false }, - completed: { archived: true }, + active: { status: 'active' }, + completed: { status: 'complete' }, } export const state2props = ({ router, ...state }) => { @@ -50,6 +51,7 @@ export const state2props = ({ router, ...state }) => { sortby: 'due_date:asc', company: undefined, project: undefined, + status: undefined, } const assignedToMapping = { diff --git a/test/functional/cypress/fakers/task.js b/test/functional/cypress/fakers/task.js index c7e5ad75c99..2838416693b 100644 --- a/test/functional/cypress/fakers/task.js +++ b/test/functional/cypress/fakers/task.js @@ -29,6 +29,7 @@ const taskFaker = (overrides = {}) => ({ modifiedBy: basicAdviserFaker(), modifiedOn: faker.date.past().toISOString(), createdOn: faker.date.past().toISOString(), + status: 'active', ...overrides, }) diff --git a/test/functional/cypress/specs/dashboard/filter-spec.js b/test/functional/cypress/specs/dashboard/filter-spec.js index b4bb74d1ac7..f42b0b9da26 100644 --- a/test/functional/cypress/specs/dashboard/filter-spec.js +++ b/test/functional/cypress/specs/dashboard/filter-spec.js @@ -300,24 +300,29 @@ describe('Task filters', () => { }) it('should filter active status from the url', () => { - testFilterFromUrl(element, 'status=active', { archived: false }, 'Active') + testFilterFromUrl( + element, + 'status=active', + { status: 'active' }, + 'Active' + ) }) it('should filter completed status from the url', () => { testFilterFromUrl( element, 'status=completed', - { archived: true }, + { status: 'complete' }, 'Completed' ) }) it('should filter active status from user input', () => { - testFilterFromUserInput(element, { archived: false }, 'Active') + testFilterFromUserInput(element, { status: 'active' }, 'Active') }) it('should filter completed status from user input', () => { - testFilterFromUserInput(element, { archived: true }, 'Completed') + testFilterFromUserInput(element, { status: 'complete' }, 'Completed') }) }) From ab6fdbf970e8a9514346faf8558038ab43e92527 Mon Sep 17 00:00:00 2001 From: santosh dasari <74972011+santoshdasa12345@users.noreply.github.com> Date: Mon, 29 Jan 2024 15:18:32 +0000 Subject: [PATCH 2/2] Add status to tasks --- src/client/components/Dashboard/my-tasks/tasks.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/client/components/Dashboard/my-tasks/tasks.js b/src/client/components/Dashboard/my-tasks/tasks.js index 934964dab15..9f14e365856 100644 --- a/src/client/components/Dashboard/my-tasks/tasks.js +++ b/src/client/components/Dashboard/my-tasks/tasks.js @@ -10,6 +10,7 @@ export const getMyTasks = ({ sortby = 'due_date:asc', company, project, + status, }) => apiProxyAxios .post('/v4/search/task', { @@ -24,5 +25,6 @@ export const getMyTasks = ({ sortby, company, investment_project: project, + status, }) .then(({ data }) => data)