Bug fix EYB lead audit log is_high_value null to boolean #7571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
bug/CLS2-1289_handle-null-to-boolean-eyb-high-value-audit-logs
|
| Run status |
|
| Run duration | 01m 44s |
| Commit |
|
| Committer | Stuart Mindt |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
santoshdasa12345
approved these changes
Feb 19, 2025
oliverjwroberts
approved these changes
Feb 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7571 +/- ##
=======================================
Coverage 90.02% 90.03%
=======================================
Files 1122 1122
Lines 17442 17444 +2
Branches 5034 5036 +2
=======================================
+ Hits 15703 15705 +2
Misses 1739 1739 ☔ View full report in Codecov by Sentry. |
stuart-mindt
deleted the
bug/CLS2-1289_handle-null-to-boolean-eyb-high-value-audit-logs
branch
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 20, 2025
) generated from commit 022d047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix EYB lead audit log is_high_value null to boolean
Description of change
EYB lead is_high_value can sometimes be null and when the value is changed to true or false and audit log is added. Users do not care for these changes so adding logic to filter these out.
Test instructions
Added test data and check to ensure the row renders correctly when thrown a null to boolean change log.
Screenshots
Before
Add a screenshot
After
Add a screenshot
Checklist