Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLS2-1246 Adding is_high_value latest audit log entry to EYB search r… #7567

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

stuart-mindt
Copy link
Contributor

@stuart-mindt stuart-mindt commented Feb 17, 2025

CLS2-1246 Adding is_high_value latest audit log entry to EYB search results

Description of change

EYB lead users want to see when their leads have change high_value in the search results page.

Test instructions

That the list items render with the audit log for high value if present and will not if not present.

Screenshots

Before

After

image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@stuart-mindt stuart-mindt requested a review from a team as a code owner February 17, 2025 16:01
Copy link

cypress bot commented Feb 17, 2025

data-hub-frontend    Run #59402

Run Properties:  status check passed Passed #59402  •  git commit 392d9abe90: Fixing test
Project data-hub-frontend
Branch Review feature/CLS2-1246_EYB-change-logs
Run status status check passed Passed #59402
Run duration 01m 39s
Commit git commit 392d9abe90: Fixing test
Committer Stuart Mindt
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (44e36a9) to head (392d9ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7567   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files        1122     1122           
  Lines       17425    17442   +17     
  Branches     5027     5034    +7     
=======================================
+ Hits        15686    15703   +17     
  Misses       1739     1739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuart-mindt stuart-mindt merged commit c8e97b6 into main Feb 19, 2025
16 checks passed
@stuart-mindt stuart-mindt deleted the feature/CLS2-1246_EYB-change-logs branch February 19, 2025 12:36
chopkinsmade pushed a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants