Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading for one list tier D to adviser core team #7566

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

santoshdasa12345
Copy link
Contributor

@santoshdasa12345 santoshdasa12345 commented Feb 17, 2025

Description of change

This PR addresses the One List Tier D - International Trade Adviser Accounts heading should be "Adviser core on team" and its association to be "Lead ITA"

Test instructions

Updated "Adviser core on team"

Screenshots

image

Add a screenshot

Uploading image.png…

Add a screenshot

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Feb 17, 2025

data-hub-frontend    Run #59429

Run Properties:  status check passed Passed #59429  •  git commit dfb2c02054: update one list tier fromname to id
Project data-hub-frontend
Branch Review CLS2-one-list-content-change-tier-d
Run status status check passed Passed #59429
Run duration 07m 58s
Commit git commit dfb2c02054: update one list tier fromname to id
Committer santosh dasari
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (44e36a9) to head (dfb2c02).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7566      +/-   ##
==========================================
+ Coverage   90.02%   90.03%   +0.01%     
==========================================
  Files        1122     1122              
  Lines       17425    17427       +2     
  Branches     5027     5029       +2     
==========================================
+ Hits        15686    15690       +4     
+ Misses       1739     1737       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santoshdasa12345 santoshdasa12345 force-pushed the CLS2-one-list-content-change-tier-d branch from 1c79cec to 946463c Compare February 19, 2025 14:35
@santoshdasa12345 santoshdasa12345 changed the title add heading advisers on core team Add heading for one list tier D to adviser core team Feb 19, 2025
@santoshdasa12345 santoshdasa12345 marked this pull request as ready for review February 19, 2025 16:12
@santoshdasa12345 santoshdasa12345 requested a review from a team as a code owner February 19, 2025 16:12
Copy link
Contributor

@stuart-mindt stuart-mindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dredmonds dredmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other dev comment has been resolved and now on A/L. Now I will approved for FE release.

@santoshdasa12345 santoshdasa12345 merged commit 49fc86d into main Feb 20, 2025
16 checks passed
@santoshdasa12345 santoshdasa12345 deleted the CLS2-one-list-content-change-tier-d branch February 20, 2025 10:28
chopkinsmade pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants