Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cls2 704 use status for active and complete #6543

Conversation

marijnkampf
Copy link
Contributor

@marijnkampf marijnkampf commented Feb 21, 2024

Description of change

Works with PR CLS2-704 on API. Allows for marking task status as active / complete.

Test instructions

Create a Task and view it. Mark it as completed using the button. View the task and it should have the Complete tag and no Mark as complete button.

Screenshots

No visual changes

image

image

image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@marijnkampf marijnkampf requested a review from a team as a code owner February 21, 2024 08:29
Copy link

cypress bot commented Feb 21, 2024

Passing run #51246 ↗︎

0 26 0 0 Flakiness 0

Details:

Fix tasks/details-spec.js
Project: data-hub-frontend Commit: f2a94a687c
Status: Passed Duration: 02:05 💡
Started: Feb 21, 2024 4:04 PM Ended: Feb 21, 2024 4:06 PM

Review all test suite changes for PR #6543 ↗︎

@marijnkampf marijnkampf changed the base branch from main to feature/task-deletion February 21, 2024 16:27
@marijnkampf marijnkampf merged commit 94e0f6f into feature/task-deletion Feb 22, 2024
16 checks passed
@marijnkampf marijnkampf deleted the feature/CLS2-704-use-status-for-active-and-complete branch February 22, 2024 07:44
marijnkampf added a commit that referenced this pull request Feb 22, 2024
* Use status for active and complete

* Add API calls to a11y test exclusion list

* Fix tasks/details-spec.js
marijnkampf added a commit that referenced this pull request Feb 26, 2024
* Use status for active and complete

* Add API calls to a11y test exclusion list

* Fix tasks/details-spec.js
marijnkampf added a commit that referenced this pull request Feb 27, 2024
* Use status for active and complete

* Add API calls to a11y test exclusion list

* Fix tasks/details-spec.js
marijnkampf added a commit that referenced this pull request Feb 28, 2024
* Use status for active and complete

* Add API calls to a11y test exclusion list

* Fix tasks/details-spec.js
marijnkampf added a commit that referenced this pull request Feb 28, 2024
* Use status complete/active instead of archive true/false (#6497 / #6543)
* Feature/cls2 695 allow for deletion of tasks (#6549)
---------
Co-authored-by: Claudia Gonzalez-Casales @ClaudiaGC1339
Co-authored-by: santosh dasari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants