Simplified redux setup #6534
Merged
Simplified redux setup #6534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #51225 ↗︎
Details:
Review all test suite changes for PR #6534 ↗︎ |
|||||||||||||||
peterhudec
force-pushed
the
fix/simplify-redux-configuration
branch
2 times, most recently
from
61c0941 to
d13d7d5
Compare
peterhudec
force-pushed
the
fix/simplify-redux-configuration
branch
from
d13d7d5 to
2042cf8
Compare
paulgain
approved these changes
Feb 21, 2024
cgsunkel
approved these changes
Feb 21, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 21, 2024
…figuration generated from commit 3d035eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Simplifies Redux setup by:
src/client/middleware.jsmodule, because only one of the three things it exported was actually a middleware.history,storeandsagaMiddlewareprops fromDataHubProvider, because they only ever were passed the same valuesreact-slotmacro and how the useless "Unexpected key ..." error (thrown by Redux'scombineReducers) is suppressedAlong the way I realized that the reasons why we had the
spa-base-pathExpress middleware are no longer valid and the middleware can be removed, so I removed it alongside the doc that was explaining its usage.Test instructions
There should be no noticable difference. All existing tests should still be passing.