Migrate company overview to React Router #6400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #49852 ↗︎
Details:
Review all test suite changes for PR #6400 ↗︎ |
|||||||||||||||
cgsunkel
force-pushed
the
feature/migrate-company-overview-to-react-router
branch
from
1e9dd6b to
88c1760
Compare
cgsunkel
commented
Jan 4, 2024
There was a problem hiding this comment.
The changes to this file are very minimal when compared with the original version
cgsunkel
commented
Jan 4, 2024
There was a problem hiding this comment.
The changes to this file are very minimal when compared with the original version
samuele-mattiuzzo
approved these changes
Jan 5, 2024
dredmonds
approved these changes
Jan 5, 2024
cgsunkel
merged commit f9f4304
into
feature-merge/company-layout-refactoring
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is the first in a series of PRs to migrate the company pages to React Router. A new version of
CompanyLayoutandCompanyLocalHeaderhave been created that works with theDefaultLayout. The old one will be removed once all pages are migrated.The company overview page has been updated in order to test the new components (this page has also been moved into the
modulesdirectory).Test instructions
Go to the overview tab for a company. Everything should work as before.
Checklist