Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial CI #12

Open
zmoon opened this issue Sep 5, 2023 · 2 comments · May be fixed by #13
Open

Initial CI #12

zmoon opened this issue Sep 5, 2023 · 2 comments · May be fixed by #13
Assignees
@zmoon
Labels
enhancement New feature or request
Milestone
03) Connect first...

Comments

@zmoon
Copy link
Collaborator

zmoon commented Sep 5, 2023 •
edited
Loading

I want to add some initial automated tests of the codebase:

  • formatting
    • for Fortran, findent
    • for text files, eliminate trailing white space
  • linting
    • CMake config + GFortran with many flags
  • tests
    • calling some of the non-driver scheme subroutines, checking results a bit maybe

These checks will run automatically in GitHub but will also be easy to run locally (and I will document how).
@zmoon
Copy link
Collaborator Author

zmoon commented Sep 5, 2023

We need to decide what findent settings to use. Does anyone familiar with findent have a strong preference? I normally just use the defaults (default indent is 3).

@bbakernoaa bbakernoaa added the enhancement New feature or request label Sep 5, 2023
@bbakernoaa
Copy link
Collaborator

bbakernoaa commented Sep 5, 2023 •
edited
Loading

I'm good with 3. Doesn't really matter to me. We just need to be consistent for readability.

@zmoon zmoon linked a pull request Sep 5, 2023 that will close this issue
Draft
11 tasks
zmoon pushed a commit to zmoon/CATChem that referenced this issue Jun 3, 2024
@bbakernoaa
Merge pull request ufs-community#12 from bbakernoaa/add_chmstate
63eb1ec 
Add chmstate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmoon zmoon

Labels
enhancement New feature or request
Projects
None yet
Milestone
03) Connect first version of CATChem ...
Development

Successfully merging a pull request may close this issue.

Initial CI zmoon/CATChem
3 participants
@zmoon @bbakernoaa @rschwant