Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quaternions instead of rotation matrixes as much as possible #68

Open
1-Bart-1 opened this issue Dec 15, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@1-Bart-1
Copy link
Collaborator

The advantages would be:

  • Quaternions are more computationally efficient
  • Quaternions don't have singularities
  • The code gets better structured and therefore easier to understand: instead of having quaternions + rotation matrixes + euler angles we only have quaternions for computation and euler angles for interpretability

A disadvantage might be that quaternions are tricky to understand. But with good functions / documentation this should be fine.

@ufechner7
Copy link
Owner

Well, there are not many conversions that are really required. The main conversion function is calc_heading(). Feel free to write a version of this function that uses quaternions. But it is not time critical, because it is called only once per timestep and not in the callback of the DAE solver.

@ufechner7 ufechner7 added the enhancement New feature or request label Dec 18, 2024
@1-Bart-1 1-Bart-1 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants