Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal_reviewers field to group #8

Closed
uesteibar opened this issue Jul 16, 2020 · 0 comments · Fixed by #17
Closed

Add internal_reviewers field to group #8

uesteibar opened this issue Jul 16, 2020 · 0 comments · Fixed by #17
Labels
enhancement New feature or request

Comments

@uesteibar
Copy link
Owner

uesteibar commented Jul 16, 2020

It would be great to have an internal_reviewers group setting, that would set how many reviews are required from that group if the PR author belongs to it. Example:

For

groups:
  - name: sample_group
    reviewers: 2
    internal_reviewers: 1
    usernames:
      - user_a
      - user_b
      - user_c
  • If user_a opens a PR, then only one reviewer (either user_b or user_c) will be assigned
  • If user_d opens a PR, then two reviewers from sample_group will be assigned

If reviewers is not added, then we should only set reviewers when a user within the team creates the PR.

@uesteibar uesteibar added the enhancement New feature or request label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant