Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling? #14

Open
dschaeffer17 opened this issue Apr 16, 2019 · 1 comment
Open

Better error handling? #14

dschaeffer17 opened this issue Apr 16, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@dschaeffer17
Copy link
Collaborator

dschaeffer17 commented Apr 16, 2019 •
edited
Loading

There are several minor (edge case) bugs in DataView that seem to crash the program (at least when run from terminal). While eventually these can be corrected, can an error handler be implemented that would catch these errors first?
@dschaeffer17 dschaeffer17 added the enhancement New feature or request label Apr 16, 2019
pheuer added a commit that referenced this issue Apr 16, 2019
@pheuer
Resolved issues #13 and #14, made window grab focus
b0c157a 
1) Resolved range=0 ValueError by adding a check to validateChoices() so that plotting routine will abort if axes are incorrectly set this way and show an informative error warning.

2) Wrapped plotting routine in an error handling statment to catch ValueErrors (although these should nominally not occur)

3) Added a line at the top that makes the window pop up on top when dataview is opened (so you don't have to go searching for it behind other windows).
@pheuer
Copy link
Member

pheuer commented Apr 16, 2019

I've added an error catching statement for ValueErrors around the plotting routine to try and make these non-fatal. Ideas for other ways of making it more stable welcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dschaeffer17 @pheuer