Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution in a larger domain is not extracted correctly #1

Open
SonyPony opened this issue Mar 29, 2022 · 2 comments
Open

Solution in a larger domain is not extracted correctly #1

SonyPony opened this issue Mar 29, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@SonyPony
Copy link
Collaborator

Using the kwave_solution, I tried to compute the wavefield in a homogenous SOS map (1 m/s) in a 96x96 domain, which resulted in a positive peak at the source location (first image).

However, if I run a simulation with the same parameters in a larger domain (512x512), the resulting wavefield has a negative peak at the source location (second image). I expected the same wavefield as in the 96x96 domain, but with "more" waves.

image
image

@SonyPony SonyPony added the bug Something isn't working label Mar 29, 2022
@SonyPony
Copy link
Collaborator Author

SonyPony commented Apr 4, 2022

@astanziola Did you manage to find the bug?

@astanziola
Copy link
Member

I gave it a try this weekend, and I don't see why it shouldn't work.

At first, I was thinking that is just a numerical issue in the way we evaluate the dt here, but seems weird (those are not very long time-stepping simulations).

Another thing that is know is that the accuracy of the single-frequency solution of PSTD simulations (that is, k-Wave) accumulates errors that only vanish for dt -> 0. But I do believe that this is compensated for in k-wave, see eq. 2.16 and relative discussion in the k-wave manual

I'm sure it is a silly error somewhere, I'll keep digging 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants