-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Manage page: Hide cancel button when updates are not in progress. #1557
fix: Manage page: Hide cancel button when updates are not in progress. #1557
Conversation
@anasereijo Is it possible to add that cancel button with singular updates also? like the |
Yes @soumyaDghosh, it would be easy to change text, but we loos the ability to indicate updates in progress as we show loading indicator on the Update all button |
Hello @Feichtmeier, thanks for suggestion to use Wrap. I have made the changes in latest commit, can you please check when feasible |
I think it looks good, even though this is not an official review since I am not the maintainer anymore here 🙏 |
LGTM ! @Feichtmeier your reviews are always welcome tho! 💙 |
The update button looks wiered here |
Hi @soumyaDghosh, thanks for reporting, I will work on the fix for this. |
@codinesh thanks.. But I have already fixed it 😁.. But thanks again for all of your work on the store. |
…dates-hide fix: Manage page: Hide cancel button when updates are not in progress.
As per the comments form #1536, this PR will hide cancel button when updates are not in progress.