Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Manage page: Hide cancel button when updates are not in progress. #1557

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

codinesh
Copy link
Contributor

@codinesh codinesh commented Jan 3, 2024

One thing to amend is that the cancel button should be hidden until the 'Update all' is trigged, as it can be misleading for the users to have a cancel button without context.

As per the comments form #1536, this PR will hide cancel button when updates are not in progress.

@soumyaDghosh
Copy link
Contributor

@anasereijo Is it possible to add that cancel button with singular updates also? like the update button will change to cancel button? @codinesh will it be easy/viable?

@codinesh
Copy link
Contributor Author

codinesh commented Jan 3, 2024

Yes @soumyaDghosh, it would be easy to change text, but we loos the ability to indicate updates in progress as we show loading indicator on the Update all button

@Feichtmeier
Copy link
Member

The cancel button overflows
grafik

you could use a wrap instead of a row to prevent this

grafik

return Wrap(
spacing: 10,
runSpacing: 10,

but then remove the sizedboxes between

@codinesh
Copy link
Contributor Author

Hello @Feichtmeier, thanks for suggestion to use Wrap. I have made the changes in latest commit, can you please check when feasible

@Feichtmeier
Copy link
Member

I think it looks good, even though this is not an official review since I am not the maintainer anymore here 🙏

@BLKKKBVSIK
Copy link
Collaborator

LGTM !

@Feichtmeier your reviews are always welcome tho! 💙

@BLKKKBVSIK BLKKKBVSIK merged commit 8eb0247 into ubuntu:main Jan 16, 2024
8 checks passed
@soumyaDghosh
Copy link
Contributor

The update button looks wiered here

Screenshot from 2024-01-19 21-12-57

@BLKKKBVSIK @anasereijo

@codinesh
Copy link
Contributor Author

The update button looks wiered here

Screenshot from 2024-01-19 21-12-57

@BLKKKBVSIK @anasereijo

Hi @soumyaDghosh, thanks for reporting, I will work on the fix for this.

@soumyaDghosh
Copy link
Contributor

@codinesh thanks.. But I have already fixed it 😁.. But thanks again for all of your work on the store.

ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
…dates-hide

fix: Manage page: Hide cancel button when updates are not in progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants