Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snap]: fix hardcoded app icon #1542

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

soumyaDghosh
Copy link
Contributor

Fixes #1514

image

@soumyaDghosh
Copy link
Contributor Author

@BLKKKBVSIK @spydon can you look into this. This is relatively small PR.

@BLKKKBVSIK
Copy link
Collaborator

LGTM

@spydon spydon merged commit d03c93a into ubuntu:main Dec 28, 2023
8 checks passed
@Feichtmeier
Copy link
Member

I don't know if this was intended, but now the icon changed to a monochrome, half transparent icon from the previous yaru full color app icon

now
image

before
image

@soumyaDghosh
Copy link
Contributor Author

@Feichtmeier that's probably not the monochrome icon, but the new icon. It's taken from here,

https://github.com/ubuntu/app-center/blob/main/packages/app_center/assets/app-center.png

Now, I am not sure, if using the svg version would fix it. And the screenshot I shared was not objected by anyone, so, probably intended

@AsciiWolf
Copy link
Contributor

AsciiWolf commented Jan 1, 2024

@soumyaDghosh I am not sure whether using a 90x90 px icon is a good idea. The svg one would probably be better. Or this png one that has better resolution (although it still is a non-standard size).

ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for Adwaita theme
5 participants