Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Change channel' shown in 2 lines #1513

Closed
fthx opened this issue Nov 29, 2023 · 10 comments · Fixed by #1828
Closed

'Change channel' shown in 2 lines #1513

fthx opened this issue Nov 29, 2023 · 10 comments · Fixed by #1828
Assignees
Labels
jira Sync with JIRA prio: low

Comments

@fthx
Copy link
Contributor

fthx commented Nov 29, 2023

Hi,

image

Could be better in 1 line only, FR version here.

@matthew-hagemann
Copy link
Collaborator

Hi @fthx, thanks for reporting this!

Feels like instead of doing a text wrap and spanning it over two lines we should swap to cutting off lines with an ellipsis if we run out of screen space. (ie: Changer de can...) @anasereijo?

@fthx
Copy link
Contributor Author

fthx commented Nov 30, 2023

Ellipsis does not look great, IMO.
image
Here we have some place for a longer string, because reducing the width shows another layout:
image
where there is a lot of place for change-channel string.

@matthew-hagemann matthew-hagemann added enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed prio: low labels Nov 30, 2023
@anasereijo
Copy link
Collaborator

Can we resize the button according to the text length?

@BLKKKBVSIK
Copy link
Collaborator

Can we resize the button according to the text length?

We can, but on long text, it will break the UI on the smallest breakpoint. Or we can cut the text off with an ellipsis only on the smallest breakpoint.

@anasereijo
Copy link
Collaborator

Or we can cut the text off with an ellipsis only on the smallest breakpoint.

That sounds good! I suppose there will be a tooltip on hover to tell the user the full label?

@fthx
Copy link
Contributor Author

fthx commented Dec 11, 2023

Means that the label will not be fully displayed?
Sorry, I don't understand this regression here.

@BLKKKBVSIK
Copy link
Collaborator

Means that the label will not be fully displayed? Sorry, I don't understand this regression here.

The label will try to be displayed fully, but depending on the window size, there might be an ellipsis with a tooltip.

@fthx
Copy link
Contributor Author

fthx commented Dec 12, 2023

Ok.
But the point I do not understand is that when the window's width is low, the "Change channel" label comes above the main info row.
image
So it seems there's not really a label's width issue?

@fthx
Copy link
Contributor Author

fthx commented Dec 18, 2023

I don' t understand the eyes.

In fact, there is a wider probleme IMO here:
image
There are two labels (package, channel/open) those widths are not dynamically set and there is a lot of space left to not ellipsize any of them.

@BLKKKBVSIK
Copy link
Collaborator

The eye emoji means that we will look into this.
I agree with you, the buttons with should depend on the length of their text.

@anasereijo anasereijo added jira Sync with JIRA and removed enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed labels Aug 16, 2024
spydon added a commit that referenced this issue Oct 7, 2024
![Screenshot from 2024-10-03
14-02-08](https://github.com/user-attachments/assets/d8ad0486-359b-4ef8-8901-f4b3ac26b0af)
![Screenshot from 2024-10-03
14-02-18](https://github.com/user-attachments/assets/daa0b66e-36d7-4626-ad5c-49ac0d7a94be)

Instead of putting using the overflow bar we'll make the switch button
flexible so that it can shrink when it needs to (and be larger when the
text is long).

Fixes: #1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira Sync with JIRA prio: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants