Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar navigation not highlighted when clicking section on explore page #1379

Closed
tim-hm opened this issue Sep 17, 2023 · 2 comments · Fixed by #1550
Closed

Sidebar navigation not highlighted when clicking section on explore page #1379

tim-hm opened this issue Sep 17, 2023 · 2 comments · Fixed by #1550
Assignees
Labels
enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed prio: low

Comments

@tim-hm
Copy link

tim-hm commented Sep 17, 2023

issue

  1. Activate explore page
  2. Scroll down to a banner (ie "Featured Snaps" or "Must have snaps for developers")
  3. Click "Discover more"
  4. The correct page is activated but it has a back button and the left side navigation isn't selected.

image

expected behaviour

When activating a 'top level' section, I would expect the left nav bar to reflect the active page.

@d-loose
Copy link
Member

d-loose commented Sep 18, 2023

That was a deliberate design choice. Do we need to rethink this? @anasereijo?

@anasereijo
Copy link
Collaborator

@d-loose as discussed on standup, if a category is selected from the Explore page, and it's also present on the side-nav, the side-nav item should become highlighted.

@anasereijo anasereijo added enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed prio: low labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed prio: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants