From 7139795d4e586a16f58e5b06a47fd01f6dd7189b Mon Sep 17 00:00:00 2001
From: Dennis Loose <dennis.loose@canonical.com>
Date: Thu, 26 Oct 2023 17:56:46 +0200
Subject: [PATCH] fix(snap-page): fix channel dropdown item height (#1474)

---
 lib/src/snapd/snap_page.dart | 72 +++++++++++++++++++-----------------
 1 file changed, 39 insertions(+), 33 deletions(-)

diff --git a/lib/src/snapd/snap_page.dart b/lib/src/snapd/snap_page.dart
index cd7816787..0374cf202 100644
--- a/lib/src/snapd/snap_page.dart
+++ b/lib/src/snapd/snap_page.dart
@@ -616,7 +616,9 @@ class _ChannelDropdown extends StatelessWidget {
                   MaterialStatePropertyAll(Size(_kChannelDropdownWidth, 200)),
               visualDensity: VisualDensity(horizontal: 0, vertical: 0),
             ),
-            itemStyle: MenuItemButton.styleFrom(),
+            itemStyle: MenuItemButton.styleFrom(
+              maximumSize: const Size.fromHeight(100),
+            ),
             child: Text(
               '${model.selectedChannel} ${model.availableChannels![model.selectedChannel]!.version}',
             ),
@@ -635,40 +637,44 @@ class _ChannelDropdownEntry extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     final l10n = AppLocalizations.of(context);
-    return DefaultTextStyle(
-      style: Theme.of(context).textTheme.bodyMedium!.copyWith(
-            overflow: TextOverflow.ellipsis,
-          ),
-      child: SizedBox(
-        width: _kChannelDropdownWidth - 24,
-        child: Row(
-          children: [
-            DefaultTextStyle.merge(
-              style: TextStyle(
-                color: Theme.of(context).hintColor,
-              ),
-              child: Column(
-                crossAxisAlignment: CrossAxisAlignment.end,
-                mainAxisSize: MainAxisSize.min,
-                children: [
-                  Text(l10n.snapPageChannelLabel),
-                  Text(l10n.snapPageVersionLabel),
-                  Text(l10n.snapPagePublishedLabel),
-                ],
-              ),
+    return Padding(
+      padding: const EdgeInsets.symmetric(vertical: 8),
+      child: DefaultTextStyle(
+        style: Theme.of(context).textTheme.bodyMedium!.copyWith(
+              overflow: TextOverflow.ellipsis,
             ),
-            const SizedBox(width: 8),
-            Flexible(
-              child: Column(
-                crossAxisAlignment: CrossAxisAlignment.start,
-                children: [
-                  channelEntry.key,
-                  channelEntry.value.version,
-                  DateFormat.yMd().format(channelEntry.value.releasedAt),
-                ].map((e) => Text(e, maxLines: 1)).toList(),
+        child: SizedBox(
+          width: _kChannelDropdownWidth - 24,
+          child: Row(
+            children: [
+              DefaultTextStyle.merge(
+                style: TextStyle(
+                  color: Theme.of(context).hintColor,
+                ),
+                child: Column(
+                  crossAxisAlignment: CrossAxisAlignment.end,
+                  mainAxisSize: MainAxisSize.min,
+                  children: [
+                    Text(l10n.snapPageChannelLabel),
+                    Text(l10n.snapPageVersionLabel),
+                    Text(l10n.snapPagePublishedLabel),
+                  ],
+                ),
               ),
-            ),
-          ],
+              const SizedBox(width: 8),
+              Flexible(
+                child: Column(
+                  crossAxisAlignment: CrossAxisAlignment.start,
+                  mainAxisSize: MainAxisSize.min,
+                  children: [
+                    channelEntry.key,
+                    channelEntry.value.version,
+                    DateFormat.yMd().format(channelEntry.value.releasedAt),
+                  ].map((e) => Text(e, maxLines: 1)).toList(),
+                ),
+              ),
+            ],
+          ),
         ),
       ),
     );