-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Things to improve #2
Comments
Any chance we could get a roadmap at some point? Appreciate the work by the way 😃 |
Maybe. Most of these are long-terms goals since they are not acute pain points for us. |
How would one go about using |
First you extract the types from the component file. Then we pass it to the Editor component.
You can see it at baseweb.design when you hover over components: We use flow but should be almost same for typescript. Ideally, we don't want to vendor that code and enable this in a simpler way. |
Thanks for the help! If I may pick your brain — what do you think about using the extracted TypeScript (or Flow) types as props to |
It would be more trouble than help. The type extraction via const Component: React.FC<PropsT & { additionalProp: string }> Even if it worked more reliably you still have to deal with more complex types like enums that often come with imports. And even "simple" boolean and string props sometimes need additional meta settings like So in the best case scenario it would be some hybrid model. You would still have to maintain some configuration for each component. Anyway, once you have these config files, you can actually use them for other things as well. For example, we generate these tables out of them (while using flow types as an additional information since they don't always work). And there are some other neat tools I want to build that will leverage the react-view props format. |
extract-react-types-loader
and the flexibility ofprism-react-renderer
to do that, solidify this API, add examples (including typescript)Concurrent Mode should also help
customProps
andprovider
, maybe explaning better how to parse ASTs and build them from scratch (the code generation part)raw
values in the AST + it's including unnecessary language extensions by default, let's figure out what to do about it ... maybe trim it even more and introduce some prettier-light version?The text was updated successfully, but these errors were encountered: