-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presentation without targetViewController should be removed #19
Comments
Internally they can still be used but can rely on the existence of a target view controller. |
In my testing using a target view controller did not always perform as expected, and in most cases one would want this media focus view to be displayed as a modal subview in the view stack of the application's keyWindow. Some of this could have to do with how iOS handles adding child view controllers via Also, it's perfectly acceptable to add one view controller's view to another view controller's view, especially if the presenting view is just a modal view on top of UIWindow which is what this control does if no target view controller is specified. The only issue with not using the I will leave this open as I'll revisit some of the weird issues with using a target view controller to see if that can be improved. |
i have just finished a first draft of the interface rotation. It somewhat relies on the the rotation calls to update the snapshots. |
Adding the view of a view controller to another view controllers view is not a good practice. We might consider deprecating the
showImage...
methods that lack theinViewController:
argument. This also reduces the number of code-branches to support and is likely to ease the handling of interface orientation.The text was updated successfully, but these errors were encountered: