Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] refactor to make sure relationdb is mariadb, to make clear the assumption in the code #49

Open
DavyLandman opened this issue Mar 3, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@DavyLandman
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As we discussed during the Athens meeting, we should not assume a ML relationaldb is always a mariadb, similar for a documentdb. It is the responsibility of DL to map it to specific backends. We do not currently have to support different backends, but we should not hard code it.

Describe the solution you'd like
In our code we also look at the DL model and use it to check what kind of backend we are running on. It is perfectly fine to only support mariadb under the relationaldb option, but the check should be there in the code, such that it remains a clear extension point.

@DavyLandman DavyLandman added the enhancement New feature or request label Mar 3, 2020
@DavyLandman DavyLandman added this to the ⛵ Final Release milestone Mar 3, 2020
@DavyLandman DavyLandman changed the title [Feature] do not depend on assumption that relational == mariadb and document=mongodb [Feature] refactor to make sure relationdb is mariadb, to make clear the assumption in the code Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants