Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this to use a golang vendor directory and use the docker plugin helper package #35

Open
pmcgrath opened this issue Apr 15, 2017 · 2 comments

Comments

@pmcgrath
Copy link

Hi,
I do not see much merging of PRs so just want to check to see if this is likely to be merged, I would like to use this plugin for some CI systems.

I would like to make the following updates

Will need to this anyway, just want to get an indication if a PR would be accepted, I don't plan to change how the plugin works, as looks perfect for my needs, so those changes would be minimal

Thanks
Pat

@pmcgrath pmcgrath changed the title Update this to use a golang vendor directory and use the docker plugin hellper package Update this to use a golang vendor directory and use the docker plugin helper package Apr 15, 2017
@liron-l
Copy link
Contributor

liron-l commented Apr 17, 2017

Hi @pmcgrath, we will appreciate a PR re vendor package and package updates.
Re plugin-helper library, this is essentially a very limited version of what this plugin does, so I'm not sure what is the added benefit, can you please explain your motivation.

pmcgrath added a commit to pmcgrath/authz that referenced this issue Apr 18, 2017
  Removed specific golang version
  We no longer need to run godep restore
pmcgrath added a commit to pmcgrath/authz that referenced this issue Apr 18, 2017
@pmcgrath
Copy link
Author

@liron-l re using the helper package, my thinking was that we would follow the docker docs convention, as you said it doesn't buy us anything, would possibly need to alter so we could both support the authorizer and auditor.

I'm happy to just to take care of the following

  • vendoring
  • Altering the makefile to address foreach not working in bash
  • Updating the order of import statements based on gofmt
  • Fixing some url's and readme content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants