From f88c6006db3e5cf40157bf9a9ce7ce11d6ac33ff Mon Sep 17 00:00:00 2001 From: Nabhag8848 Date: Fri, 23 Aug 2024 00:31:31 +0530 Subject: [PATCH] fix: more naming conventions --- .../src/hooks/useDefaultHomePagePath.tsx | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/packages/twenty-front/src/hooks/useDefaultHomePagePath.tsx b/packages/twenty-front/src/hooks/useDefaultHomePagePath.tsx index c50cff4bf755..ae854d001891 100644 --- a/packages/twenty-front/src/hooks/useDefaultHomePagePath.tsx +++ b/packages/twenty-front/src/hooks/useDefaultHomePagePath.tsx @@ -15,7 +15,7 @@ export const useDefaultHomePagePath = () => { const currentUser = useRecoilValue(currentUserState); const { activeObjectMetadataItems, alphaSortedActiveObjectMetadataItems } = useFilteredObjectMetadataItems(); - const { records } = usePrefetchedData(PrefetchKey.AllViews); + const { records: views } = usePrefetchedData(PrefetchKey.AllViews); const { lastVisitedObjectMetadataItemId } = useLastVisitedObjectMetadataItem(); let objectMetadata: { @@ -27,7 +27,7 @@ export const useDefaultHomePagePath = () => { return { defaultHomePagePath: AppPath.SignInUp }; } - const getActiveObjectMetadataMatchingId = (objectMetadataId: string) => { + const getActiveObjectMetadataItemMatchingId = (objectMetadataId: string) => { return activeObjectMetadataItems.find( (item) => item.id === objectMetadataId, ); @@ -36,24 +36,26 @@ export const useDefaultHomePagePath = () => { const getFirstObjectInfo = () => { const [metadata] = alphaSortedActiveObjectMetadataItems; - const view = getViewMatchingObjectId(metadata.id); + const view = getViewMatchingObjectMetdataItemId(metadata.id); return { metadata, view }; }; - const getViewMatchingObjectId = (objectMetadataId: string) => - records.find((view: any) => view?.objectMetadataId === objectMetadataId); + const getViewMatchingObjectMetdataItemId = (objectMetadataId: string) => + views.find((view: any) => view?.objectMetadataId === objectMetadataId); // last visited page exist in localstorage if (!isNull(lastVisitedObjectMetadataItemId)) { - const lastVisitedMetadata = getActiveObjectMetadataMatchingId( + const lastVisitedObjectMetadataItem = getActiveObjectMetadataItemMatchingId( lastVisitedObjectMetadataItemId, ); // and last visited page is still active - if (!isUndefined(lastVisitedMetadata)) { + if (!isUndefined(lastVisitedObjectMetadataItem)) { objectMetadata = { - view: getViewMatchingObjectId(lastVisitedObjectMetadataItemId), - metadata: lastVisitedMetadata, + view: getViewMatchingObjectMetdataItemId( + lastVisitedObjectMetadataItemId, + ), + metadata: lastVisitedObjectMetadataItem, }; } else { // if not fallback to alphabetically first