Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to lemon-rs for parsing? #163

Closed
penberg opened this issue Jul 16, 2024 · 6 comments
Closed

Switch to lemon-rs for parsing? #163

penberg opened this issue Jul 16, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed performance question Further information is requested

Comments

@penberg
Copy link
Collaborator

penberg commented Jul 16, 2024

The sqlite3-parser crate we use for SQL parsing is surprisingly slow. Let's look into using lemon-rs like libSQL does, which may be faster.
@penberg penberg added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 16, 2024
@penberg penberg changed the title Switch to lemon-rs for parsing` Switch to lemon-rs for parsing`? Jul 16, 2024
@penberg penberg added question Further information is requested performance labels Jul 16, 2024
@penberg penberg changed the title Switch to lemon-rs for parsing`? Switch to lemon-rs for parsing? Jul 16, 2024
@adiSuper94
Copy link

Hi @penberg I'd like to take a crack at this.

@penberg
Copy link
Collaborator Author

penberg commented Jul 16, 2024

Let's wait to see what happens with gwenn/lemon-rs#57 first. If it's merged, this issue is essentially resolved.

@pereman2
Copy link
Collaborator

sqlite3-parser == lemon-rs right?

@penberg
Copy link
Collaborator Author

penberg commented Jul 16, 2024

I think lemon-rs has a lower level API than the one we use, but can be wrong too

@pereman2
Copy link
Collaborator

https://crates.io/crates/sqlite3-parser look at repo

@penberg
Copy link
Collaborator Author

penberg commented Jul 21, 2024

Obsoleted by https://github.com/penberg/limbo/issues/185

@penberg penberg closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed performance question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@penberg @adiSuper94 @pereman2