From 1c3608f1684ba504ea659dd016a27fa442ef4435 Mon Sep 17 00:00:00 2001 From: ospanovalen Date: Thu, 14 Dec 2023 15:02:04 +0300 Subject: [PATCH] Update getting-started-with-tungsten-fabric-development.rst Signed-off-by: ospanovalen ospanov.a@phystech.edu --- .../getting-started-with-tungsten-fabric-development.rst | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/contributing-to-tungsen-fabric/getting-started/getting-started-with-tungsten-fabric-development.rst b/contributing-to-tungsen-fabric/getting-started/getting-started-with-tungsten-fabric-development.rst index de8dbba..dc9bd91 100644 --- a/contributing-to-tungsen-fabric/getting-started/getting-started-with-tungsten-fabric-development.rst +++ b/contributing-to-tungsen-fabric/getting-started/getting-started-with-tungsten-fabric-development.rst @@ -57,6 +57,9 @@ Copy the entire output line(your public ssh id) 5. Add SSH key +6. Make sure that in GitHub settings in Public profile you have public email(that you will add to global git config) + This is required for the correct operation of the Gerrit + 2. Tungsten Fabric + Devstack setup(Ansible Deployer) ----------------------------------------------------- @@ -130,7 +133,7 @@ https://gerrit-review.googlesource.com/Documentation/user-notify.html 3.1 Setup SSH access -------------------- -1. Log into your account at https://tf-gerrit.gz1.progmaticlab.com (also via GitHub) +1. Log into your account at https://tf-gerrit.gz1.progmaticlab.com (via GitHub) 2. Go to top-right corner -> settings @@ -195,8 +198,6 @@ https://gerrit-review.googlesource.com/Documentation/user-notify.html :: - git push ssh://username@tf-gerrit.gz1.progmaticlab.com:29418/REPOSITORY_NAME \ - HEAD:refs/for/%topic=, \ - r=reviewername@someone.com, cc=otherreviewer@someone.com + git review NOTE. If any of the steps above have raised questions, you can read the documentation at the link above