Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needNewKFAfter not update #49

Open
match08 opened this issue Mar 4, 2020 · 1 comment
Open

needNewKFAfter not update #49

match08 opened this issue Mar 4, 2020 · 1 comment

Comments

@match08
Copy link

match08 commented Mar 4, 2020

needNewKFAfter not update?, if not linearizeOperation must update, dso:
if(needKF) needNewKFAfter=fh->shell->trackingRef->id;
@NikolausDemmel
Copy link
Contributor

Yes, looks like the flag needNewKFAfter is not really used since it is not updated, but I can't easily tell what are the consequences. Have you analysed in which scenario this causes an issue?

@gaoxiang12 did some refactoring compared to DSO, so the flag might also be obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NikolausDemmel @match08