Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cluster.addMultipleTargetTopics _slightly_ more effecient #1731

Open
alphashuro opened this issue Jan 3, 2025 · 0 comments
Open

Make cluster.addMultipleTargetTopics _slightly_ more effecient #1731

alphashuro opened this issue Jan 3, 2025 · 0 comments

Comments

@alphashuro
Copy link

alphashuro commented Jan 3, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe.
I'm seeing a lot of timeout acquiring lock errors in a project I inherited, and tracked it down to repeated calls to send causing the mutatingTargetTopics lock to be waited on many times. This is unexpected, as the number of target topics actually used is quite low, and I would not expect the targetTopics to be mutated if they have not actually changed.

Describe the solution you'd like
I would like to have the lock skipped entirely unless the target topics have actually changed.

I have implemented this in a draft PR here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alphashuro