Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong length of f_reg in evaluate_hessian #5

Open
lwitthaus opened this issue Mar 8, 2023 · 0 comments
Open

Wrong length of f_reg in evaluate_hessian #5

lwitthaus opened this issue Mar 8, 2023 · 0 comments

Comments

@lwitthaus
Copy link
Contributor

I think the lengths of f_reg and self.reg_factor_f are not equal in

ln_f_reg_used = np.log(f_reg * self.reg_factor_f)

if a certain number of bins is ignored in the regularization.
I believe adding the line f_reg = f_reg[self._f_slice] between
if self._tau is not None:
if self.log_f_reg:

would solve the problem, just as it is done here:
if self._tau is not None:
f_reg = f_reg[self._f_slice]
if self.log_f_reg:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant