Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MKVTOOLNIX doesn't recognisze .srt files as good .srt files and fails #4

Open
felisucoibi opened this issue Oct 3, 2016 · 2 comments
Open

MKVTOOLNIX doesn't recognisze .srt files as good .srt files and fails #4

felisucoibi opened this issue Oct 3, 2016 · 2 comments

Comments

@felisucoibi
Copy link

Seems there's something not perfect because of the mkvtoolnix doesn't accept generated .srt files...
@outhud
Copy link

outhud commented Jan 3, 2017

It seems this tool doesn't produce compliant srt files, it's missing the numbers before each subtitle, as required by mkvtoolnix as in this example: https://matroska.org/technical/specs/subtitles/srt.html

@anthonygore
Copy link

I think this tool assumes the line numbers will be in the VTT file. I'm creating a PR to fix it.

@anthonygore anthonygore mentioned this issue Mar 1, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felisucoibi @anthonygore @outhud