Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate surface tagging on roadway and crossing #13

Open
watmildon opened this issue Apr 30, 2024 · 2 comments
Open

Coordinate surface tagging on roadway and crossing #13

watmildon opened this issue Apr 30, 2024 · 2 comments

Comments

@watmildon
Copy link

My current work pattern is to add surface tagging and fix alignment of roads, then work on sidewalks. Occasionally I will miss a roadway surface tag and it (obviously) won't get picked up on the crossing node. Maybe it's better as a validator step but it could be nice to have surface tags from roadways proactively applied to crossings.

@tsmock
Copy link
Owner

tsmock commented May 1, 2024

This is a harder problem to solve.
Yes, I could do that (and it might make sense for crossings without a surface tag), but I would not want to copy a conflicting surface tag over.

Realistically, I can justify copying the surface tag from a highway to the crossing on crossing creation -- the user is more likely to fix the surface data at that time.

Copying the surface tag from the highway to the crossing after the fact is a bit harder to justify. I'd rather have the user look at each crossing individually, instead of mass editing crossings.

I'd rather have no information than wrong information, and I think it is substantially more likely for that to happen when copying surface data from a highway to a crossing when adding the surface to a highway.

In other words, a validator rule would be more appropriate.

EDIT: Removing surface tagging when changing a highway surface might be appropriate though.

@watmildon
Copy link
Author

That's totally reasonable. I'll try and pay attention and see if there are any unambiguous cases but it does seem to be tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants