Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading "Sending 8192 bytes" log messages #33

Closed
l29ah opened this issue Feb 26, 2021 · 2 comments
Closed

Misleading "Sending 8192 bytes" log messages #33

l29ah opened this issue Feb 26, 2021 · 2 comments
Labels
Milestone

Comments

@l29ah
Copy link

l29ah commented Feb 26, 2021

On the debug log level, uftpd sends only one or two Sending 8192 bytes messages, even though it in fact sends much more data over the data connection.

@troglobit
Copy link
Owner

OK. Patches welcoome

@troglobit troglobit added this to the v2.14 milestone Nov 30, 2021
@troglobit
Copy link
Owner

Turns out this is by design, I had completely forgot about it. The idea was to throttle output to stdout/syslog for large files:

uftpd/src/ftpcmd.c

Lines 1060 to 1065 in 889d886

gettimeofday(&tv, NULL);
if (tv.tv_sec - ctrl->tv.tv_sec > 3) {
DBG("Sending %zd bytes of %s to %s ...", num, ctrl->file, ctrl->clientaddr);
ctrl->tv.tv_sec = tv.tv_sec;
}

I'm going to close with wontfix on this issue, but any redesign to make this better is of course welcome as a pull request. I have no interest though in changing this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants