Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance default logging #28

Closed
mnhauke opened this issue Dec 29, 2019 · 2 comments
Closed

Enhance default logging #28

mnhauke opened this issue Dec 29, 2019 · 2 comments

Comments

@mnhauke
Copy link
Contributor

mnhauke commented Dec 29, 2019

In ad-hoc ftp/tftp scenarios it would be nice to also have logging for:

  • requested files, even if those could not be found on the server
  • requested files in case those aren't accessable (insufficient permissions,...)

in non-debug log levels (notice/info).
@troglobit
Copy link
Owner

Good idea! I've intentionally reduced the verbosity until a request like yours.

These events are possibly to be classified as LOG_NOTICE, rather than LOG_INFO which has lower priority. The notice log level is also the default of uftpd, so that would also make sense. A user who don't want these messages could either filter them out in /etc/syslogd.conf or adjust the log-level uftpd is started with to error. What do you think, would you like to submit a patch/pull-request?

@mnhauke
Copy link
Contributor Author

mnhauke commented Dec 30, 2019

#29

@troglobit troglobit mentioned this issue Dec 30, 2019
Closed
troglobit added a commit that referenced this issue Jan 1, 2020
@troglobit
Issue #28: Further enhance logging at default log level
745ce08 
uftpd runs at loglevel notice by default.  This patch changes the level
of the following messages to notice

- FTP: successful download
- FTP: mtime change
- FTP: successful upload
- FTP: deleted file/directory
- FTP: successful creation of directory
- TFTP: RRQ
- TFTP: WRQ

Also, add FTP status message (sent to user) when user issues FTP RMD to
delete a file and fails due to directory not empty.  (Not logged)

Signed-off-by: Joachim Nilsson <[email protected]>
troglobit added a commit that referenced this issue Jan 1, 2020
@troglobit
Merge branch 'mnhauke-master'
7c099ed 
Close #28, #29

Signed-off-by: Joachim Nilsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troglobit @mnhauke