Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for REST #13

Closed
troglobit opened this issue May 20, 2018 · 4 comments
Closed

Add support for REST #13

troglobit opened this issue May 20, 2018 · 4 comments
Milestone

Comments

@troglobit
Copy link
Owner

troglobit commented May 20, 2018

When transferring a large file the transfer can be interrupted by network problems or the client pausing the transfer. To restart a RETR, or STOR, we need to support REST.

This issue is instrumental to getting the VLC Android app. mentioned in issue #9 to work.

@troglobit troglobit added this to the v2.5 milestone May 20, 2018
@oz123
Copy link
Contributor

oz123 commented Jun 2, 2018

@troglobit I looked at the source code for pyftpdlib for REST. Seems easy enough to implement.
My real life work in C is very limited, but this would be a perfect learning ground (large enough code base, but not to large), to implement a real code. Would you accept a my PR for this?

@troglobit
Copy link
Owner Author

Yup, that's it. A restart marker/offset and then use it for the next STOR or RETR command, but then you also need to support ABOR to reset the operation ... that's how it started for me; "just a small little function, how hard could it be?!"

To answer your question: No. But only because I have a whole week of unpushed patches lined up in my own queue, one of them being REST. I've planned to finalize and push them this weekend.

@oz123
Copy link
Contributor

oz123 commented Jun 2, 2018

Oh, well! Thanks for the honest answer. I will use your patched to learn by reading.

troglobit added a commit that referenced this issue Jun 3, 2018
@troglobit
Copy link
Owner Author

Complete support added in refactor af54295.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants