Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic haptic feedback support #40

Closed
danielreuterwall opened this issue Sep 20, 2024 · 4 comments
Closed

Generic haptic feedback support #40

danielreuterwall opened this issue Sep 20, 2024 · 4 comments

Comments

@danielreuterwall
Copy link

The Haptic feedback is limited to use the Expo module. If we would allow a callback as a prop instead of the whole module we could support a generic haptic feedback implementation and allow you to configure the feedback as needed.

<TimerPicker
   ...
   Haptics={() => trigger("impactLight")}
/>

Possible renamning the props to something like hapticFeedback.
The same could be used for audio feedback as well. What do you think?

@troberts-28
Copy link
Owner

Hey @danielreuterwall,

Thank you for this! Definitely makes sense to make it generic rather than limiting it to Expo (I selfishly did that because I just needed the Haptics to work in Expo). I should be able to do this at some point in the next few months, or I'd be very happy to review a PR if you'd like to have a go?

@danielreuterwall
Copy link
Author

I can definitely fix a PR for that. Should I fix the audio feedback in the way, while I'm at it?

@troberts-28
Copy link
Owner

Great stuff. Yes please!

@troberts-28
Copy link
Owner

This has now been released in v2.0.0. Thanks again @danielreuterwall 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants