From 0f4c54685ae4b05147d38a92f36dfbc27e0fd355 Mon Sep 17 00:00:00 2001 From: Tristan Montoya Date: Tue, 7 Jan 2025 10:15:42 -0500 Subject: [PATCH] fix mistake in comment --- src/equations/covariant_advection.jl | 5 ++--- src/equations/covariant_shallow_water.jl | 4 ++-- src/equations/reference_data.jl | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/equations/covariant_advection.jl b/src/equations/covariant_advection.jl index 0347be2..1d2c21c 100644 --- a/src/equations/covariant_advection.jl +++ b/src/equations/covariant_advection.jl @@ -87,9 +87,8 @@ end return SVector(u[1], z, z) end -# Flux for abstract covariant equations as a function of the state vector u, as well as the -# auxiliary variables aux_vars, which contain the geometric information required for the -# covariant form +# Flux as a function of the state vector u, as well as the auxiliary variables aux_vars, +# which contain the geometric information required for the covariant form @inline function Trixi.flux(u, aux_vars, orientation::Integer, equations::CovariantLinearAdvectionEquation2D) z = zero(eltype(u)) diff --git a/src/equations/covariant_shallow_water.jl b/src/equations/covariant_shallow_water.jl index 29de7cc..0316c3c 100644 --- a/src/equations/covariant_shallow_water.jl +++ b/src/equations/covariant_shallow_water.jl @@ -141,8 +141,8 @@ end return 0.5f0 * (dot(vcov, vcon) + equations.gravity * h^2) end -# The flux for the covariant form takes in the element container and node/element indices -# in order to give the flux access to the geometric information +# Flux as a function of the state vector u, as well as the auxiliary variables aux_vars, +# which contain the geometric information required for the covariant form @inline function Trixi.flux(u, aux_vars, orientation::Integer, equations::CovariantShallowWaterEquations2D) h, h_vcon1, h_vcon2 = u diff --git a/src/equations/reference_data.jl b/src/equations/reference_data.jl index 8c27a80..8171029 100644 --- a/src/equations/reference_data.jl +++ b/src/equations/reference_data.jl @@ -155,7 +155,7 @@ This problem corresponds to Case 5 of the test suite described in the following K = 7.848f-6 R = 4.0f0 - A = 0.5f0 * K * (2 * EARTH_ROTATION_RATE + omega) * (cos(lat))^2 + + A = 0.5f0 * omega * (2 * EARTH_ROTATION_RATE + omega) * (cos(lat))^2 + 0.25f0 * K^2 * (cos(lat))^(2 * R) * ((R + 1) * (cos(lat))^2 + (2 * R^2 - R - 2) - 2 * R^2 / ((cos(lat))^2)) B = 2 * (EARTH_ROTATION_RATE + omega) * K / ((R + 1) * (R + 2)) * (cos(lat))^R *