Skip to content
This repository has been archived by the owner on Dec 27, 2021. It is now read-only.

Function defined twice and missing options #26

Open
rstech209 opened this issue May 28, 2021 · 1 comment
Open

Function defined twice and missing options #26

rstech209 opened this issue May 28, 2021 · 1 comment

Comments

@rstech209
Copy link

rstech209 commented May 28, 2021

Hi,
First of all, many thanks for sharing your scripts.
Looking at the star.sh script, I saw that several functions were defined twice ...
Non-exhaustive list:
show_summary ()
run_calc ()
run_tar ()
The progress of the script seems to complete successfully, but it seems "dangerous".
On the other hand, I see 2 other potential problems:

  1. In "Transfer" mode, hard links are not preserved by the default options of rsync: No -H option
    (no problem for "backup" mode because tar natively takes into account the hard links).
    -S (--sparse) option is missing too in default options, for copying sparse files efficiently.
  2. In the "restore" mode, it seems important to provide the --numeric-owner option because of the use of an intermediate system (liveCD or liveUSB)
    see this point here http://www.gnu.org/software/tar/manual/tar.html#Attributes ; ‘--numeric-owner’
    an here : https://help.ubuntu.com/community/BackupYourSystem/TAR
@tritonas00
Copy link
Owner

Hi!

functions were defined twice

They are defined according to specific mode, so only once at time.

No -H option

You are right.

--numeric-owner

You can set it using custom options.

I do not plan to continue this project, so please fork and modify to your needs. Thank you for your time!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants