Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of device settings when discovery is not finished kills my device #4385

Closed
tomasklim opened this issue Oct 18, 2021 · 5 comments · Fixed by #16528
Closed

Change of device settings when discovery is not finished kills my device #4385

tomasklim opened this issue Oct 18, 2021 · 5 comments · Fixed by #16528
Assignees
Labels
bug Something isn't working as expected code Code improvements

Comments

@tomasklim
Copy link
Member

tomasklim commented Oct 18, 2021

Describe the bug
This bug affects only me from dev team. I am the only one using Intel mac.
When I want to change settings of device before discovery is done, it kills my device. It happens on both Bridge and Web USB.

Background
When user navigates to different route than Dashboard and Accounts when discovery is in progress, the discovery process is paused.

Steps to reproduce:

  1. Open Suite
  2. Select wallet type
  3. During discovery process open Settings
  4. Try to change settings of device. (PIN, image, name,...)
  5. You get errorError: assertType: Response of unexpected type: Features. Should be Success
  6. Device is stuck and you cannot do anything
  7. Refresh app
  8. Loading takes too long

You need to replug device to be able to use Suite.

Info:

  • Suite version: web 21.10.2 (3cb57ea)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36
  • OS: MacIntel
  • Screen: 1920x1080
  • Device: model 1 1.10.3 regular
  • Transport: USB API, Bridge

It happens also with trezor-user-env

@tomasklim tomasklim changed the title Change of device settings when discovery is not finished Change of device settings when discovery is not finished kills my device Oct 18, 2021
@tsusanka
Copy link
Contributor

Might be related #4268 and #4383

@alex-jerechinsky alex-jerechinsky added the bug Something isn't working as expected label Oct 19, 2021
@bosomt bosomt added code Code improvements HIGH labels Oct 22, 2021
@hynek-jina hynek-jina moved this to 🎯 To do in Suite Desktop Feb 9, 2022
@tomasklim tomasklim assigned mroz22 and unassigned tomasklim Feb 24, 2022
@hynek-jina hynek-jina removed the HIGH label Jun 8, 2022
@STew790
Copy link
Contributor

STew790 commented Jul 26, 2022

I am not sure if it is the exact same issue, nonetheless, when I try to toggle PIN "ON" for example, while the discovery is going on, the whole Settings menu is "stuck" and you can only change app settings. The "Crypto" settings is all greyed out.
image

When you go to "Dashboard" or "Account" the wallet won't load and I get a bit different error (maybe wording changed?).
image

Also, the device isn't "soft-locked" and I could just refresh the app. This applies to both devices.

Info:

  • Suite version: desktop 22.7.3 (8eddb2a)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.7.3 Chrome/100.0.4896.160 Electron/18.3.5 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.5.1 regular (revision null)
  • Transport: bridge 2.0.31

@bosomt
Copy link
Contributor

bosomt commented Jul 26, 2022

I think this is part of "don't do anything during discovery" problem ;)
It usually ends with only one option and to reconnect device.

@hynek-jina hynek-jina removed the status in Suite Desktop Feb 9, 2023
@MiroslavProchazka MiroslavProchazka added this to the Github grooming milestone May 24, 2024
@bosomt
Copy link
Contributor

bosomt commented May 31, 2024

Only valid for Check device now , all other buttons are already disabled in settings/device during discovery.
You can press it and get Error: Unable to validate device: Device call in progress
All we have to do is to disable this button during discovery and we can close this one

image

Info:

  • Suite version: desktop 24.5.3 (0ff3e0b)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.5.3 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2B1 2.7.0 regular (revision 45e8a842a31e62a6d43d7f6ccac62a45e1198ef0)
  • Transport: BridgeTransport 2.0.33

@bosomt
Copy link
Contributor

bosomt commented Jan 24, 2025

QA OK

Info:

  • Suite version: web 25.2.0 (61f1d57)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: WebUsbTransport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected code Code improvements
Projects
Status: ✅ Approved
9 participants