-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EAS builds by downgrading eas-cli to 14.7 fixed version #16887
Conversation
WalkthroughThe changes update the GitHub Actions workflow configurations by replacing the generic “latest” version of the EAS (Expo Application Services) tool with an explicit fixed version “14.7.1”. This update occurs in both the build-suite-native-preview and release-suite-native-production workflows. The change standardizes the EAS version used in all setup steps across different platforms and workflows without affecting the underlying logic, control flow, error handling, or public entity declarations. Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
10499a0
to
e549011
Compare
- eas-cli 15 break our CI builds
e549011
to
4f7f53a
Compare
🚀 Expo preview is ready!
|
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
Description
Since eas-cli@15 has been published, all of our eas builds on CI have been failing with
git clone --no-hardlinks --depth 1 file:///home/runner/work/trezor-suite/trezor-suite /tmp/runner/eas-cli-nodejs/6792bb74-cf45-45d6-928a-56bc57a7fbb7-shallow-clone exited with non-zero code: 128
error.
I believe the error means that there are files too deep in the folder structure because node_modules are included even if they should not be.
It's probably this issue expo/eas-cli#2882
Let's downgrade to unblock our builds and try to resolve the issue so we can update the expo-cli again.