Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EAS builds by downgrading eas-cli to 14.7 fixed version #16887

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

matejkriz
Copy link
Member

@matejkriz matejkriz commented Feb 7, 2025

Description

Since eas-cli@15 has been published, all of our eas builds on CI have been failing with
git clone --no-hardlinks --depth 1 file:///home/runner/work/trezor-suite/trezor-suite /tmp/runner/eas-cli-nodejs/6792bb74-cf45-45d6-928a-56bc57a7fbb7-shallow-clone exited with non-zero code: 128
error.

I believe the error means that there are files too deep in the folder structure because node_modules are included even if they should not be.

It's probably this issue expo/eas-cli#2882

Let's downgrade to unblock our builds and try to resolve the issue so we can update the expo-cli again.

Copy link

coderabbitai bot commented Feb 7, 2025

Walkthrough

The changes update the GitHub Actions workflow configurations by replacing the generic “latest” version of the EAS (Expo Application Services) tool with an explicit fixed version “14.7.1”. This update occurs in both the build-suite-native-preview and release-suite-native-production workflows. The change standardizes the EAS version used in all setup steps across different platforms and workflows without affecting the underlying logic, control flow, error handling, or public entity declarations.

Suggested reviewers

  • szymonlesisz
  • martykan
  • PeKne

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0ae958 and 4f7f53a.

📒 Files selected for processing (2)
  • .github/workflows/build-suite-native-preview.yml (1 hunks)
  • .github/workflows/release-suite-native-production.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: e2e-test-suite-web (@group_wallet, trezor-user-env-unix bitcoin-regtest, 1)
🔇 Additional comments (4)
.github/workflows/build-suite-native-preview.yml (1)

48-48: EAS Version Downgrade for Build Preview Job
The explicit update of eas-version to 14.7.1 meets the PR objective to avoid failures caused by eas-cli v15. This change should restore build stability for the preview workflow.

.github/workflows/release-suite-native-production.yml (3)

37-39: EAS Version Update in iOS Job
The change on line 38, setting eas-version to 14.7.1 for the iOS build step, is in line with the intended downgrade. This ensures the iOS build uses the fixed version, preventing build failures linked to v15.


65-66: EAS Version Update in Android Job
The Android build’s Setup EAS step is now set to use eas-version: 14.7.1, ensuring consistency across platforms and aligning with the PR objective.


93-94: EAS Version Update in Android APK Job
Similarly, the Setup EAS step for the Android APK job now uses the explicit version 14.7.1, which helps maintain uniformity and should prevent issues due to the newer eas-cli version.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matejkriz matejkriz added mobile Suite Lite issues and PRs build-mobile Trigger manual Suite Lite Preview build on PR labels Feb 7, 2025
@matejkriz matejkriz force-pushed the chore/native/fix-develop-build branch from 10499a0 to e549011 Compare February 7, 2025 14:28
@matejkriz matejkriz force-pushed the chore/native/fix-develop-build branch from e549011 to 4f7f53a Compare February 7, 2025 14:44
Copy link

github-actions bot commented Feb 7, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@matejkriz matejkriz changed the title WIP chore(suite-native): eas require commit Fix EAS builds by downgrading eas-cli to 14.7 fixed version Feb 7, 2025
@matejkriz matejkriz added ci Continuous Integration (CI) related and removed build-mobile Trigger manual Suite Lite Preview build on PR labels Feb 7, 2025
@matejkriz matejkriz requested a review from a team February 7, 2025 14:58
@matejkriz matejkriz added the no-project This label is used to specify that PR doesn't need to be added to a project label Feb 7, 2025
@matejkriz matejkriz marked this pull request as ready for review February 7, 2025 14:58
@matejkriz matejkriz requested a review from vdovhanych as a code owner February 7, 2025 14:58
@matejkriz matejkriz merged commit 8a6cb64 into develop Feb 7, 2025
37 of 40 checks passed
@matejkriz matejkriz deleted the chore/native/fix-develop-build branch February 7, 2025 15:04
PeKne added a commit that referenced this pull request Feb 11, 2025
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
PeKne added a commit that referenced this pull request Feb 11, 2025
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
PeKne added a commit that referenced this pull request Feb 11, 2025
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration (CI) related mobile Suite Lite issues and PRs no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants