New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBF transaction mined before RBFed #16875

Closed

6 tasks done

peter-sanderson opened this issue Feb 6, 2025 · 0 comments · Fixed by #16905

Closed

6 tasks done

RBF transaction mined before RBFed #16875

peter-sanderson opened this issue Feb 6, 2025 · 0 comments · Fixed by #16905

Assignees

Contributor

peter-sanderson commented Feb 6, 2025 •

edited

Loading

Follow-up of: #6810

Figma: https://www.figma.com/design/a13eFaT5HqemGmzJZy1fNg/Transactions?node-id=1-106&p=f&t=gzu2w9XlIcp7l0Rm-0

When user is trying to perform RBF or Cancel and original TX gets confirmed, the modal shall change to error state

There are 6 cases that needs to be handled correctly:

RBF:

RBF Detail Modal feat: add error screen for RBF modal when TX is confirmed #16893
RBF Review TX Sign feat: add error state for RBF when previous transaction gets mined befor user sends the modal #16878
RBF Review TX Broadcast feat: add error state for RBF when previous transaction gets mined befor user sends the modal #16878

Cancel:

Cancel Detail Modal (done in prev. PR) feat: Cancel Transaction #16525
Cancel Review TX Sign feat: implement distinction between BumpFee RBF & Cancel RBF -> utilise it to display error in case TX gets confirmed in cancel flow #16905
Cancel Review TX Broadcast feat: implement distinction between BumpFee RBF & Cancel RBF -> utilise it to display error in case TX gets confirmed in cancel flow #16905

peter-sanderson self-assigned this

github-project-automation bot added this to Suite Desktop

github-project-automation bot moved this to 🎯 To do in Suite Desktop

This was referenced Feb 6, 2025

feat: add error state for RBF when previous transaction gets mined befor user sends the modal #16878

Merged

feat: add error screen for RBF modal when TX is confirmed #16893

Merged

feat: implement distinction between BumpFee RBF & Cancel RBF -> utilise it to display error in case TX gets confirmed in cancel flow #16905

Merged

peter-sanderson moved this from 🎯 To do to 🔎 Needs review in Suite Desktop

peter-sanderson closed this as completed in #16905

github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment