Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Trade section under feature flag #16514

Closed
4 tasks done
vytick opened this issue Jan 21, 2025 · 2 comments · Fixed by #16574
Closed
4 tasks done

Introduce Trade section under feature flag #16514

vytick opened this issue Jan 21, 2025 · 2 comments · Fixed by #16574
Assignees
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker

Comments

@vytick
Copy link
Contributor

vytick commented Jan 21, 2025

We want to start developing Trade and want start to add it to the app. To do that we want to introduce featureflag and add new stack+ empty screen to tab bar.

  • add new feature flag to featureFlagsSlice and set default value to false and add ui to module-dev-utils like for other ff
  • add new stack in package module-trading for trade feature with new empty screen that will be initial screen for this
  • add new icon for that tab based on the docs
  • add this to tab bar according to the design

Expected outcome:

  • Unless featureflag is enabled, there is no Trade tab
  • ff can be enabled in Dev utils
  • Trade tab is present once ff is enabled
  • On selecting the tab, there is new empty screen
@vytick vytick added the mobile Suite Lite issues and PRs label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Jan 21, 2025
@jbazant jbazant self-assigned this Jan 22, 2025
@jbazant jbazant moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Jan 22, 2025
@vytick vytick changed the title Introduce Coinmarket under feature flag Introduce Trade section under feature flag Jan 22, 2025
@vytick vytick moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Jan 24, 2025
@vytick
Copy link
Contributor Author

vytick commented Jan 28, 2025

@trezor/qa Please add to sanity tests, that Trade tab is not visible on iOS or on Android in release build.

@STew790
Copy link
Contributor

STew790 commented Feb 7, 2025

QA OK

  • added that trade tab should be hidden behind ff to sanity tests
  • trade tab is visible after enabling ff in the bottom bar
  • trade tab has an "empty" placeholder screen:

Image

Info
25.1.3 3a8d2da

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Feb 7, 2025
@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

3 participants