Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat convert cy pw suite settings #15796

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Feat convert cy pw suite settings #15796

merged 4 commits into from
Dec 9, 2024

Conversation

Vere-Grey
Copy link
Contributor

@Vere-Grey Vere-Grey commented Dec 5, 2024 •
edited
Loading

Parent: #15606
Converts another cypress test file to playwright. Not completely refactored as is our plan.
Solves disabling of hash check so we can work with TS3 and TS5.

  • Electron disables it on start with params. This happens always.
  • Web disables it on demand during run of browser. We decided to do it at start Onboarding. That way both Electron app and Web have same state
  • Web relies on passing window.Playwright flag to the context to trigger binding of Redux store to the window and being accessible.
  • For some reason disabling the hash check is not enough. You have to also toggle the Debug settings on. I will inquire whether that is expected.

@Vere-Grey Vere-Grey marked this pull request as draft December 5, 2024 17:23
@Vere-Grey
feat(e2e): Convertin test suite t2b1-deivice-setting to playwright
0897702 
- deals with disabling hash check on both web and electron
- enables full configuration of Trezor emulator start from any test
@Vere-Grey
feat(e2e): Removes converted cy test t2b1-device-settings
3a203e7
@Vere-Grey Vere-Grey force-pushed the feat-convert-cy-pw-suite-settings branch from 9c57740 to 3a203e7 Compare December 5, 2024 17:24
@Vere-Grey Vere-Grey self-assigned this Dec 5, 2024
@Vere-Grey Vere-Grey marked this pull request as ready for review December 5, 2024 17:24
@Vere-Grey Vere-Grey force-pushed the feat-convert-cy-pw-suite-settings branch from 2221053 to 5c6e90d Compare December 5, 2024 18:45
@Vere-Grey
Copy link
Contributor Author

Mystery error
https://github.com/trezor/trezor-suite/actions/runs/12186089492/job/33993884352?pr=15796#step:5:591

@Vere-Grey Vere-Grey force-pushed the feat-convert-cy-pw-suite-settings branch 5 times, most recently from 45cb757 to a345197 Compare December 6, 2024 10:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 17
  • More info

Learn more about 𝝠 Expo Github Action

@Vere-Grey Vere-Grey force-pushed the feat-convert-cy-pw-suite-settings branch from a345197 to d9480cb Compare December 6, 2024 13:36
@Vere-Grey Vere-Grey force-pushed the feat-convert-cy-pw-suite-settings branch 3 times, most recently from 4c17bf8 to 252531b Compare December 6, 2024 16:09
@Vere-Grey
fix(e2e): Fix homescreen gallery click that is flaky
a517d0e 
adds a wait for image load of button that was flaky to click
@Vere-Grey Vere-Grey force-pushed the feat-convert-cy-pw-suite-settings branch from 252531b to a517d0e Compare December 6, 2024 17:58
@HajekOndrej HajekOndrej merged commit c5b661d into develop Dec 9, 2024
69 of 70 checks passed
@HajekOndrej HajekOndrej deleted the feat-convert-cy-pw-suite-settings branch December 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HajekOndrej HajekOndrej HajekOndrej approved these changes

@mroz22 mroz22 Awaiting requested review from mroz22

Assignees

@Vere-Grey Vere-Grey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vere-Grey @HajekOndrej