Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trading - No offers when opening DEX Compare all offers #15668

Closed
bosomt opened this issue Dec 2, 2024 · 5 comments · Fixed by #16436
Closed

Trading - No offers when opening DEX Compare all offers #15668

bosomt opened this issue Dec 2, 2024 · 5 comments · Fixed by #16436
Assignees
@adderpositive
Labels
bug Something isn't working as expected +Invity Related to Invity project

Comments

@bosomt
Copy link
Contributor

bosomt commented Dec 2, 2024

Describe the bug
No offers when opening DEX Compare all offers
Offer is available, i open all offers and not a single offer.
When i go back token is not selected anymore but Eletereum is selected

Steps to reproduce:

  1. Try to swap Eth tokens via DEX
  2. Select Compare all offers
  3. Observe options and try to go back to see what token is selected

Info:

  • Suite version: desktop 24.12.0 (16cbfef)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.12.0 Chrome/130.0.6723.91 Electron/33.1.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 688bddc887b8bb660640cc6e40a99036f2e87f1f)
  • Transport: BridgeTransport 2.0.33

Screenshots:

Screen.Recording.2024-12-02.at.11.38.49.mov
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Dec 2, 2024
@bosomt bosomt added the bug Something isn't working as expected label Dec 2, 2024
@adderpositive adderpositive added the +Invity Related to Invity project label Dec 2, 2024
@bosomt bosomt changed the title No offers when opening DEX Compare all offers Trading - No offers when opening DEX Compare all offers Dec 2, 2024
@adderpositive adderpositive self-assigned this Jan 13, 2025
@FreeWall FreeWall marked this as a duplicate of #16375 Jan 15, 2025
@adderpositive adderpositive mentioned this issue Jan 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 21, 2025
@adderpositive
Copy link
Contributor

adderpositive commented Jan 21, 2025 •
edited
Loading

Some notes on this issue:

  • ✅ No offers when opening DEX Compare all offers - is fixed by the PR connected to this issue
  • ☑️_Offer is available, i open all offers and not a single offer_ - could you please create follow up issue?
  • ✅_When i go back token is not selected anymore but Eletereum is selected_ - is fixed here fix(trade): persistent form state #16332

@bosomt
Copy link
Contributor Author

bosomt commented Jan 22, 2025

QA NOK

@adderpositive still not persistent , when i get back from Compare offers via back button Eth is selected and not token i selected previously

Screen.Recording.2025-01-22.at.10.20.58.mov

Info:

  • Suite version: web 25.2.0 (551157e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1920x1080
  • Device: Trezor T2B1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to 🎯 To do in Suite Desktop Jan 22, 2025
@adderpositive
Copy link
Contributor

@bosomt check my comment. The connected PR does not cover the persistency of the form.

@bosomt
Copy link
Contributor Author

bosomt commented Jan 22, 2025

@adderpositive oh i see its not merged yet :)

@bosomt
Copy link
Contributor Author

bosomt commented Jan 22, 2025

QA OK

Info:

  • Suite version: web 25.2.0 (551157e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1920x1080
  • Device: Trezor T2B1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🎯 To do to ✅ Approved in Suite Desktop Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adderpositive adderpositive

Labels
bug Something isn't working as expected +Invity Related to Invity project
Projects
Suite Desktop
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(trade): display DEX quotes trezor/trezor-suite
2 participants
@adderpositive @bosomt