Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify "NetworkSymbol" all around the codebase #14812

Closed
2 tasks
tomasklim opened this issue Oct 11, 2024 · 1 comment
Closed
2 tasks

Unify "NetworkSymbol" all around the codebase #14812

tomasklim opened this issue Oct 11, 2024 · 1 comment
Assignees

Comments

@tomasklim
Copy link
Member

tomasklim commented Oct 11, 2024

NetworkSymbol can be btc, eth, sol,...

Right now, in codebase we use bunch of different naming for NetworkSymbol

  • symbol
  • coin
  • networkSymbol
  • asset
  • logo
  • and many more...

Some networks (Optimism, BNB Smart Chain, Base,...) have different identificator of the network (op, bsc, base) than native coin (eth, bnb, eth). We need to introduce also something like DisplaySymbol, NativeSymbol, NativeCoin,... name TBD

First step should be to try unify naming of NetworkSymbol.

Unfortunately Connect uses coin, Blockbook uses symbol, so we should stick to using symbol as we do not want to transfer data.

Refactor all occurrences in suite to

  • symbol where it is mix of token symbol and network symbol
  • networkSymbol where it is just network symbol

On some places we type token symbols as NetworkSymbol using as which is definitely not correct

@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Oct 11, 2024
@tomasklim tomasklim self-assigned this Oct 11, 2024
@tomasklim tomasklim moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Dec 7, 2024
@tomasklim tomasklim assigned adderpositive and unassigned tomasklim Dec 7, 2024
@tomasklim
Copy link
Member Author

Probably duplicated of #14725

@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Dec 7, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants