You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, in codebase we use bunch of different naming for NetworkSymbol
symbol
coin
networkSymbol
asset
logo
and many more...
Some networks (Optimism, BNB Smart Chain, Base,...) have different identificator of the network (op, bsc, base) than native coin (eth, bnb, eth). We need to introduce also something like DisplaySymbol, NativeSymbol, NativeCoin,... name TBD
First step should be to try unify naming of NetworkSymbol.
Unfortunately Connect uses coin, Blockbook uses symbol, so we should stick to using symbol as we do not want to transfer data.
Refactor all occurrences in suite to
symbol where it is mix of token symbol and network symbol
networkSymbol where it is just network symbol
On some places we type token symbols as NetworkSymbol using as which is definitely not correct
The text was updated successfully, but these errors were encountered:
NetworkSymbol
can bebtc
,eth
,sol
,...Right now, in codebase we use bunch of different naming for
NetworkSymbol
symbol
coin
networkSymbol
asset
logo
Some networks (Optimism, BNB Smart Chain, Base,...) have different identificator of the network (
op
,bsc
,base
) than native coin (eth
,bnb
,eth
). We need to introduce also something likeDisplaySymbol
,NativeSymbol
,NativeCoin
,... name TBDFirst step should be to try unify naming of
NetworkSymbol
.Unfortunately Connect uses
coin
, Blockbook usessymbol
, so we should stick to usingsymbol
as we do not want to transfer data.Refactor all occurrences in suite to
symbol
where it is mix of token symbol and network symbolnetworkSymbol
where it is just network symbolOn some places we type token symbols as
NetworkSymbol
usingas
which is definitely not correctThe text was updated successfully, but these errors were encountered: