Make Clippy happy

trailofbits · Jan 11, 2024 · e845a4a · e845a4a
1 parent 8661abd
commit e845a4a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/cargo-dylint/tests/fix.rs b/cargo-dylint/tests/fix.rs
@@ -74,7 +74,6 @@ fn fix() {
 fn append_workspace_metadata(path: &Path) -> Result<()> {
     let manifest = path.join("Cargo.toml");
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(&manifest)
         .with_context(|| format!("Could not open `{}`", manifest.to_string_lossy()))?;

diff --git a/cargo-dylint/tests/metadata.rs b/cargo-dylint/tests/metadata.rs
@@ -25,7 +25,6 @@ fn invalid_pattern() {
             .unwrap();
 
         let mut file = OpenOptions::new()
-            .write(true)
             .append(true)
             .open(tempdir.path().join("Cargo.toml"))
             .unwrap();
@@ -73,7 +72,6 @@ fn list() {
         .unwrap();
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(tempdir.path().join("Cargo.toml"))
         .unwrap();
@@ -112,7 +110,6 @@ fn metadata_change() {
     isolate(tempdir.path()).unwrap();
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(tempdir.path().join("Cargo.toml"))
         .unwrap();
@@ -174,7 +171,6 @@ fn nonexistent_git_library() {
         .unwrap();
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(tempdir.path().join("Cargo.toml"))
         .unwrap();
@@ -229,7 +225,6 @@ fn nonexistent_path_library() {
     isolate(tempdir.path()).unwrap();
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(tempdir.path().join("Cargo.toml"))
         .unwrap();
@@ -285,7 +280,6 @@ fn rustflags_change() {
     isolate(tempdir.path()).unwrap();
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(tempdir.path().join("Cargo.toml"))
         .unwrap();
@@ -330,7 +324,6 @@ fn unknown_keys() {
         .unwrap();
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(tempdir.path().join("Cargo.toml"))
         .unwrap();

diff --git a/examples/experimental/missing_doc_comment_openai/src/lib.rs b/examples/experimental/missing_doc_comment_openai/src/lib.rs
@@ -181,9 +181,7 @@ impl<'tcx> LateLintPass<'tcx> for MissingDocCommentOpenai {
         }
 
         let doc_comment = std::env::var(OPENAI_API_KEY).ok().and_then(|api_key| {
-            let Some(snippet) = snippet_opt(cx, item.span) else {
-                return None;
-            };
+            let snippet = snippet_opt(cx, item.span)?;
 
             let request = self.request_from_snippet(&snippet);
 

diff --git a/internal/src/packaging.rs b/internal/src/packaging.rs
@@ -41,7 +41,6 @@ pub fn new_template(to: &Path) -> Result<()> {
 pub fn isolate(path: &Path) -> Result<()> {
     let manifest = path.join("Cargo.toml");
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(&manifest)
         .with_context(|| format!("Could not open `{}`", manifest.to_string_lossy()))?;
@@ -63,7 +62,6 @@ pub fn use_local_packages(path: &Path) -> Result<()> {
     let manifest = path.join("Cargo.toml");
 
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(&manifest)
         .with_context(|| format!("Could not open `{}`", manifest.to_string_lossy()))?;