i18nValidationErrorFactory INTERNAL SERVER ERROR

[Natchii59]

Hello, I just tested nestjs-i18n in my nestjs application with a GraphQL api. I would like to use it for DTO validations, to translate my messages.

I have this setup:

• app.module.ts

I18nModule.forRoot({
  fallbackLanguage: 'en',
  loaderOptions: {
    path: join(__dirname, 'i18n'),
    watch: true
  },
  resolvers: [CookieResolver, AcceptLanguageResolver]
}),

• main.ts

app.useGlobalPipes(new I18nValidationPipe())
app.useGlobalFilters(new I18nValidationExceptionFilter())

• create-user.input.ts

@InputType()
export class CreateUserInput {
  @Field(() => String, { description: 'Username of user' })
  @Matches(/^[a-z0-9_]{3,}$/, {
    message: i18nValidationMessage('validation.USERNAME_FORMAT', {
      lang: 'fr'
    })
  })
  @Transform(({ value }) => value.toLowerCase())
  username: User['username']

  @Field(() => String, { description: 'Password of user' })
  @Matches(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*\W).{12,}$/, {
    message: i18nValidationMessage('validation.PASSWORD_FORMAT')
  })
  password: User['password']
}

When the validations are bad, I get this error.

[stigmat4j]

the same problem

[leandrofreire08]

Got the same if I don't add the ValidationPipe to the global:

app.useGlobalPipes(
    new ValidationPipe(),
    new I18nValidationPipe({ transform: true }),
  )

but still couldn't make the translation work with DTO

[rubiin]

and . I was not able to replicate

[rubiin]

The code can be found here https://github.com/toonvanstrijp/nestjs-i18n/tree/main/samples/dto-validation

[stigmat4j]

I think I have more to do with graphql, but maybe you can help?

[rubiin]

If you could provide me a repro. The exception filter is meant to be used with HTTP as far as I know.

[stigmat4j]

no, there is support for graphql. Errors are even translated

[rubiin]

so in what part, is the error you are facing

[stigmat4j]

sorry for not explaining right away.

I copied the source code myself and wrote the console.log. There are translations in object, but INTERNAL_SERVER_ERROR is returned to the graphql-playground

[stigmat4j]

@rubiin any updates?

[rubiin]

I would require a minimal reproduction

[stigmat4j]

Hello, @rubiin
https://github.com/stigmat4j/test-i18n-nest-with-graphql

[stigmat4j]

@rubiin any updates?

[rubiin]

Not really. Seems something broken on the exceptionfiler to my knowledge

[stigmat4j]

I still haven't solved this problem. Debugging didn't work, I just don't see where this message is coming from.

[gijsmin]

same for me

[TuxIceland]

I've been messing around a bit to try to solve this problem and at the end I found a way to work around it: I created a filter class on my own (I named it 'GqlValidationExceptionFilter') and I had noticed that apollo wouldn't change the response regardless of what I returned on the filter catch function; I did some trial and error here and there, until I tried throwing "new Error("Test.")" inside my filter catch function instead of returning something. Finally, something that worked: Apollo would in that case catch the error and show it in the response. I helped myself by also logging things in the 'GraphQLModule.forRoot()' 'formatError(formattedError, error)' method in order to see what was it doing. At the end, I found out that by throwing a UserInputError - imported from '@nestjs/apollo' package - inside the filter with the already formatted i18nValidationError in the extensions field it would actually work! So here's the code of my filter:

// gql-validation-exception.filter.ts

import { UserInputError } from '@nestjs/apollo';
import { ArgumentsHost, Catch } from '@nestjs/common';
import { GqlArgumentsHost, GqlExceptionFilter } from '@nestjs/graphql';
import {
  I18nValidationException,
  I18nValidationExceptionFilter,
} from 'nestjs-i18n';

@Catch(I18nValidationException)
export class GqlValidationExceptionFilter implements GqlExceptionFilter {
  catch(exception: I18nValidationException, host: ArgumentsHost) {
    const gqlHost = GqlArgumentsHost.create(host);

    const i18nError = new I18nValidationExceptionFilter().catch(
      exception,
      gqlHost,
    );

    throw new UserInputError('Bad request.', {
      extensions: { i18nError },
    });
  }
}

Now one can format the error here as intended.
Remember of course to replace 'I18nValidationExceptionFilter()' with this filter in 'app.useGlobalFilters()' in main.ts;

Probably not the best of solutions, but I hope this gives some tips to solve the issue.