Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some content is being inverted in toolbox queue overlays with dark mode #765

Open
creesch opened this issue Jun 5, 2023 · 1 comment
Open
Labels

Comments

@creesch
Copy link
Member

creesch commented Jun 5, 2023

https://www.reddit.com/r/toolbox/comments/13tv7tq/dark_mode_inverted_post_colors/

@creesch creesch added the bug something isn't working label Jun 5, 2023
@eritbh
Copy link
Member

eritbh commented Aug 2, 2023

The issue isn't CSS being applied twice like creesch mentioned in the Reddit post; the embedded document is not having the dark theme style applied at all, rather the iframe itself is being inverted by Toolbox. To fix this we'd need to not apply the inversion to the iframe and then get the embedded document to use dark theme styles itself when the embedding document is in dark theme.

There's no way to do CSS across document boundaries, so fixing this will require us to somehow communicate theme information between the main page and the instance of Toolbox running in the embedded page. I'm not excited about this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants