Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon rotation #3

Open
themmes opened this issue Oct 29, 2018 · 2 comments
Open

Polygon rotation #3

themmes opened this issue Oct 29, 2018 · 2 comments

Comments

@themmes
Copy link
Contributor

themmes commented Oct 29, 2018

I wanted to add the rotation function to polygon as well (I did this for the original pycsg), do you have an idea how we should do this robustly? As rotating influences point and plane, so maybe we should either rotate plane and update points, or rotate points and update plane? And this probably should have an effect on the BSP tree.
@themmes
Copy link
Contributor Author

themmes commented Oct 29, 2018

For now I copied rotation from solid to polygon, let me know if you want PR for this.

Random thought; I was thinking, maybe each geometry (solid, polygon) needs a reference plane and origin, that could also reduce coordinate length and make manipulation universal...

@tomturner
Copy link
Owner

Happy to have a PR for any enhancements / bug fixes

@themmes themmes mentioned this issue Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomturner @themmes