Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All access to MessagePart options and attrs should use proper accessors #35

Open
tomtkarl opened this issue Feb 13, 2013 · 2 comments
Open

All access to MessagePart options and attrs should use proper accessors #35

tomtkarl opened this issue Feb 13, 2013 · 2 comments
Assignees
@tomtkarl
Labels
enhancement
Milestone
Copper

Comments

@tomtkarl
Copy link
Owner

As above - options and attrs should be private members of MessagePart, not public.
@ghost ghost assigned tomtkarl Feb 13, 2013
@tomtkarl
Copy link
Owner Author

Alternatively, don't use accessors since there are no side effects?

@tomtkarl
Copy link
Owner Author

DataRecognisers as in #37 could well involved accessor side effects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomtkarl tomtkarl

Labels
enhancement
Projects
None yet
Milestone
Copper
Development

No branches or pull requests
1 participant
@tomtkarl