Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser stalls during development saves #455

Closed
felixunivers opened this issue Feb 13, 2019 · 5 comments
Closed

Browser stalls during development saves #455

felixunivers opened this issue Feb 13, 2019 · 5 comments

Comments

@felixunivers
Copy link

Minimal reproduction of the bug with instructions:

Expected behavior:

Other information:

I would be willing to submit a PR to fix this issue:

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@felixunivers
Copy link
Author

felixunivers commented Feb 13, 2019

Thank you for the starter - very good project for learning Angular techniques.
While experimenting with my own components I occasionally omit a bug or a typo and that gets the entire application into stall. In browser debugger the count of errors goes to thousands and the browser stalls. The only way to get out of it is to kill the process. I am assuming this may have something to do with the Redux library. It appears however, there is an endless loop somewhere when an error is detected. Perhaps you could have a look into it and force a stop on the first error or few errors?
To reproduce this behaviour is simple. Just make a few errors in your template or ts code and save (while in ng serve mode).

@timdeschryver
Copy link
Collaborator

Hi, do you got a reproduction of this? This shouldn't be happening... 🤔

@felixunivers
Copy link
Author

Sorry, for the dealy. I tried now some errors and compiling on the original 'starter' project and I do not seam to be able to reproduce the behavior there. However, in my project based on the 'starter' where I have made some additions (not too many), I am experiencing the described issues. I tried to isolate it, but my experience with Angular and TS is still rather of a "semi-educated novice" and I could not get to the bottom of it. If someone is eager to dig around , I'll be happy to upload my project somewhere.

@felixunivers
Copy link
Author

I think I figured out the way to reproduce the issue, so I am re-opening this one for your input. Thank you.
Please see:
ngrx/ngrx.github.io#17

@tomastrajan
Copy link
Owner

Project went through major update to Angular 8, please open new issue if the behavior persists. ( Old issue cleanup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants