No output on v1.2 with findbugs

[sjudd]

I've attempted to add this to Glide here so that it's possible to see violations in travis-ci directly. There's a pending commit here: sjudd/glide@5e21322.

I've added a findbugs failure which I see in the gradle output (./gradlew :library:check) but I don't see any output or failure from this plugin.

[tomasbjerre]

You need to specify the pattern to let the plugin identify the findbugs report-file. Also to make that task run after check has been completed.

Here is my script:
https://github.com/tomasbjerre/gradle-scripts/blob/master/src/main/resources/java.gradle

I use it in git-changelog-lib, if you do ./gradlew build -i it will output some comments.

[sjudd]

Wups, added the violations task to that commit: sjudd/glide@8bcafac.

./gradlew :library:check still produces no output, but adding -i does, thanks! It might be worth adding that to the readme if that's expected. I also see that you've mentioned that the plugin can "Optionally fail the build depending on violations found." in the readme, but I don't see the option to do that (though I'll probably find it by looking).

[tomasbjerre]

Ok. Yes it will fail if the maxViolations property is lower then number of found violations.

[sjudd]

Setting maxViolations to 0 does fail the build, but it doesn't produce the report without -i, would you mind changing it so that it logs the report without a failure only with -i but always logs the report if maxViolations is exceeded?

[tomasbjerre]

Im not sure how to do that. Perhaps the whole log can be the message string of the exception that fails the build. But yes, Ill have a look. Den 25 dec. 2017 22:19 skrev "Sam" <[email protected]>:

…

Setting maxViolations to 0 does fail the build, but it doesn't produce the report without -i, would you mind changing it so that it logs the report without a failure only with -i but always logs the report if maxViolations is exceeded? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa1E6wH_mNDbTipA9Rs4Bh-R5zLlDjaks5tEBF0gaJpZM4RMY2n> .

[sjudd]

Yeah I was thinking I'd try that. I'm happy to try to figure it out and send you a pull request, it may take me a few days because I'll have to get approval for the patch before I send it, but perhaps there's no rush.

Thanks for doing this, neat library!

[tomasbjerre]

Ok yes, sure!