Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement to :as-is? for specific value conversions #41

Open
codeperfector opened this issue May 2, 2021 · 2 comments
Open

enhancement to :as-is? for specific value conversions #41

codeperfector opened this issue May 2, 2021 · 2 comments

Comments

@codeperfector
Copy link
Contributor

:as-is? was introduced in a previous issue as a solution to handle situations where number conversion is attempted if a value is a date or an ip address. #27
But I think it is still useful to preserve the normal parsing behavior of cprop for all other values in my env or property edn files.
I proposed a way to allow this using :as-is-paths which is a set of paths that can be provided for which if the property keys match, then no value conversion is done. All other values are parsed in the normal manner.
See PR #40

@tolitius
Copy link
Owner

I took some time to sleep on it, since new flags tend to pile up and complect things
but I do agree this is a needed functionality
thank you for your contribution, I left some comments on the pull request

@codeperfector
Copy link
Contributor Author

Thanks for looking at my PR. I updated the branch with an additional commit for the changes you requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants